refactor #32
Open
refactor #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ccoVeille
commented
Sep 18, 2024
ccoVeille
commented
- chore: refactor code
- fix: missing check on lower boundary for Int64
- fix: underflow with min int64 with floats
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 114 129 +15
=========================================
+ Hits 114 129 +15 ☔ View full report in Codecov by Sentry. |
- remove assertNotNegative - use checkLowerBoundary
it doesn't underflow due to float imprecision
ldemailly
reviewed
Sep 18, 2024
| // the number was between 0.99 and 1.01 of the minimum value | ||
| // once converted back and forth, we need to check if the value is in the same range | ||
| // if not, so it's an underflow | ||
| return conv >= b*0.99 |
There was a problem hiding this comment.
that can't be correct even with a lot more nines?
I suggest you write a function to find how many mantisse bits there are in float64 (the answer is 53 but it's better to "prove" it) and float32 and use that as boundary tests (tests, not for runtime, imo, the runtime is covered by the roundtrip conversion, afaik)
There was a problem hiding this comment.
I wrote such function in fortio/safecast#8
or you can hardcode 53 and 24 bits as defined by the IEEE standard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.